From 678a659ddae8eab1d38dbd0d3f374e6007ce110d Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Mon, 11 Sep 2023 21:25:19 +0000 Subject: [PATCH] refactor: refactor unnecessary `else` / `elif` when `if` block has a `return` statement The use of `else` or `elif` becomes redundant and can be dropped if the last statement under the leading `if` / `elif` block is a `return` statement. In the case of an `elif` after `return`, it can be written as a separate `if` block. For `else` blocks after `return`, the statements can be shifted out of `else`. Please refer to the examples below for reference. Refactoring the code this way can improve code-readability and make it easier to maintain. --- lynxie/commands/image.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lynxie/commands/image.py b/lynxie/commands/image.py index 43eaded..d89db2d 100644 --- a/lynxie/commands/image.py +++ b/lynxie/commands/image.py @@ -19,10 +19,10 @@ class Img(commands.Cog): async def get_image_attachments(ctx): if ctx.message.attachments: return ctx.message.attachments[0] - elif ctx.message.reference: + if ctx.message.reference: if ctx.message.reference.resolved.attachments: return ctx.message.reference.resolved.attachments[0] - elif ( + if ( ctx.message.reference.resolved.embeds and ctx.message.reference.resolved.embeds[0].image ):