[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/HOS/Tamper/InstructionHelper.cs

@@ -32,33 +32,28 @@ namespace Ryujinx.HLE.HOS.Tamper
                 return (ICondition)InstructionHelper.Create(conditionType, width, lhs, rhs);
             }
 
-            switch (comparison)
+            return comparison switch
             {
-                case Comparison.Greater       : return Create(typeof(CondGT<>));
-                case Comparison.GreaterOrEqual: return Create(typeof(CondGE<>));
-                case Comparison.Less          : return Create(typeof(CondLT<>));
-                case Comparison.LessOrEqual   : return Create(typeof(CondLE<>));
-                case Comparison.Equal         : return Create(typeof(CondEQ<>));
-                case Comparison.NotEqual      : return Create(typeof(CondNE<>));
-                default:
-                    throw new TamperCompilationException($"Invalid comparison {comparison} in Atmosphere cheat");
-            }
+                Comparison.Greater => Create(typeof(CondGT<>)),
+                Comparison.GreaterOrEqual => Create(typeof(CondGE<>)),
+                Comparison.Less => Create(typeof(CondLT<>)),
+                Comparison.LessOrEqual => Create(typeof(CondLE<>)),
+                Comparison.Equal => Create(typeof(CondEQ<>)),
+                Comparison.NotEqual => Create(typeof(CondNE<>)),
+                _ => throw new TamperCompilationException($"Invalid comparison {comparison} in Atmosphere cheat"),
+            };
         }
 
         public static Object Create(Type instruction, byte width, params Object[] operands)
         {
-            Type realType;
-
-            switch (width)
+            Type realType = width switch
             {
-                case 1: realType = instruction.MakeGenericType(typeof(byte)); break;
-                case 2: realType = instruction.MakeGenericType(typeof(ushort)); break;
-                case 4: realType = instruction.MakeGenericType(typeof(uint)); break;
-                case 8: realType = instruction.MakeGenericType(typeof(ulong)); break;
-                default:
-                    throw new TamperCompilationException($"Invalid instruction width {width} in Atmosphere cheat");
-            }
-
+                1 => instruction.MakeGenericType(typeof(byte)),
+                2 => instruction.MakeGenericType(typeof(ushort)),
+                4 => instruction.MakeGenericType(typeof(uint)),
+                8 => instruction.MakeGenericType(typeof(ulong)),
+                _ => throw new TamperCompilationException($"Invalid instruction width {width} in Atmosphere cheat"),
+            };
             return Activator.CreateInstance(realType, operands);
         }