HLE: Refactoring of ApplicationLoader (#4480)

* HLE: Refactoring of ApplicationLoader * Fix SDL2 Headless * Addresses gdkchan feedback * Fixes LoadUnpackedNca RomFS loading * remove useless casting * Cleanup and fixe empty application name * Remove ProcessInfo * Fixes typo * ActiveProcess to ActiveApplication * Update check * Clean using. * Use the correct filepath when loading Homebrew.npdm * Fix NRE in ProcessResult if MetaLoader is null * Add more checks for valid processId & return success * Add missing logging statement for npdm error * Return result for LoadKip() * Move error logging out of PFS load extension method This avoids logging "Could not find Main NCA" followed by "Loading main..." when trying to start hbl. * Fix GUIs not checking load results * Fix style and formatting issues * Fix formatting and wording * gtk: Refactor LoadApplication() --------- Co-authored-by: TSR Berry <20988865+TSRBerry@users.noreply.github.com>
2023-03-31 21:16:46 +02:00 · 2023-03-31 21:16:46 +02:00 · 4c2d9ff3ff
commit 4c2d9ff3ff
parent 8198b99935
41 changed files with 1567 additions and 1322 deletions
--- a/Ryujinx.HLE/Loaders/Processes/Extensions/FileSystemExtensions.cs
+++ b/Ryujinx.HLE/Loaders/Processes/Extensions/FileSystemExtensions.cs
@ -0,0 +1,133 @@
+using LibHac.Common;
+using LibHac.Fs;
+using LibHac.Fs.Fsa;
+using LibHac.Loader;
+using LibHac.Ns;
+using LibHac.Tools.FsSystem;
+using Ryujinx.Common.Configuration;
+using Ryujinx.Common.Logging;
+using Ryujinx.HLE.Loaders.Executables;
+using Ryujinx.Memory;
+using System.Linq;
+using static Ryujinx.HLE.HOS.ModLoader;
+
+namespace Ryujinx.HLE.Loaders.Processes.Extensions
+{
+    static class FileSystemExtensions
+    {
+        public static MetaLoader GetNpdm(this IFileSystem fileSystem)
+        {
+            MetaLoader metaLoader = new();
+
+            if (fileSystem == null || !fileSystem.FileExists(ProcessConst.MainNpdmPath))
+            {
+                Logger.Warning?.Print(LogClass.Loader, "NPDM file not found, using default values!");
+
+                metaLoader.LoadDefault();
+            }
+            else
+            {
+                metaLoader.LoadFromFile(fileSystem);
+            }
+
+            return metaLoader;
+        }
+
+        public static ProcessResult Load(this IFileSystem exeFs, Switch device, BlitStruct<ApplicationControlProperty> nacpData, MetaLoader metaLoader, bool isHomebrew = false)
+        {
+            ulong programId = metaLoader.GetProgramId();
+
+            // Replace the whole ExeFs partition by the modded one.
+            if (device.Configuration.VirtualFileSystem.ModLoader.ReplaceExefsPartition(programId, ref exeFs))
+            {
+                metaLoader = null;
+            }
+
+            // Reload the MetaLoader in case of ExeFs partition replacement.
+            metaLoader ??= exeFs.GetNpdm();
+
+            NsoExecutable[] nsoExecutables = new NsoExecutable[ProcessConst.ExeFsPrefixes.Length];
+
+            for (int i = 0; i < nsoExecutables.Length; i++)
+            {
+                string name = ProcessConst.ExeFsPrefixes[i];
+
+                if (!exeFs.FileExists($"/{name}"))
+                {
+                    continue; // File doesn't exist, skip.
+                }
+
+                Logger.Info?.Print(LogClass.Loader, $"Loading {name}...");
+
+                using var nsoFile = new UniqueRef<IFile>();
+
+                exeFs.OpenFile(ref nsoFile.Ref, $"/{name}".ToU8Span(), OpenMode.Read).ThrowIfFailure();
+
+                nsoExecutables[i] = new NsoExecutable(nsoFile.Release().AsStorage(), name);
+            }
+
+            // ExeFs file replacements.
+            ModLoadResult modLoadResult = device.Configuration.VirtualFileSystem.ModLoader.ApplyExefsMods(programId, nsoExecutables);
+
+            // Take the Npdm from mods if present.
+            if (modLoadResult.Npdm != null)
+            {
+                metaLoader = modLoadResult.Npdm;
+            }
+
+            // Collect the Nsos, ignoring ones that aren't used.
+            nsoExecutables = nsoExecutables.Where(x => x != null).ToArray();
+
+            // Apply Nsos patches.
+            device.Configuration.VirtualFileSystem.ModLoader.ApplyNsoPatches(programId, nsoExecutables);
+
+            // Don't use PTC if ExeFS files have been replaced.
+            bool enablePtc = device.System.EnablePtc && !modLoadResult.Modified;
+            if (!enablePtc)
+            {
+                Logger.Warning?.Print(LogClass.Ptc, $"Detected unsupported ExeFs modifications. PTC disabled.");
+            }
+
+            // We allow it for nx-hbloader because it can be used to launch homebrew.
+            bool allowCodeMemoryForJit = programId == 0x010000000000100DUL || isHomebrew;
+
+            string programName = "";
+
+            if (!isHomebrew && programId > 0x010000000000FFFF)
+            {
+                programName = nacpData.Value.Title[(int)device.System.State.DesiredTitleLanguage].NameString.ToString();
+
+                if (string.IsNullOrWhiteSpace(programName))
+                {
+                    programName = nacpData.Value.Title.ItemsRo.ToArray().FirstOrDefault(x => x.Name[0] != 0).NameString.ToString();
+                }
+            }
+
+            // Initialize GPU.
+            Graphics.Gpu.GraphicsConfig.TitleId = $"{programId:x16}";
+            device.Gpu.HostInitalized.Set();
+
+            if (!MemoryBlock.SupportsFlags(MemoryAllocationFlags.ViewCompatible))
+            {
+                device.Configuration.MemoryManagerMode = MemoryManagerMode.SoftwarePageTable;
+            }
+
+            ProcessResult processResult = ProcessLoaderHelper.LoadNsos(
+                device,
+                device.System.KernelContext,
+                metaLoader,
+                nacpData.Value,
+                enablePtc,
+                allowCodeMemoryForJit,
+                programName,
+                metaLoader.GetProgramId(),
+                null,
+                nsoExecutables);
+
+            // TODO: This should be stored using ProcessId instead.
+            device.System.LibHacHorizonManager.ArpIReader.ApplicationId = new LibHac.ApplicationId(metaLoader.GetProgramId());
+
+            return processResult;
+        }
+    }
+}