Mirrors/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Ryujinx.Audio] Address dotnet-format issues (#5362)

Browse source 
* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>
This commit is contained in:
TSRBerry 2023-07-02 01:27:18 +02:00 • committed by GitHub
parent 0684b00b3c
commit 515fc32b21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
207 changed files with 1354 additions and 1670 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/Ryujinx.Audio/Renderer/Server/Splitter/SplitterState.cs
View file

@ -43,7 +43,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
/// <summary>
/// Span to the first element of the linked list of <see cref="SplitterDestination"/>.
/// </summary>
public Span<SplitterDestination> Destinations
public readonly Span<SplitterDestination> Destinations
{
get
{
@ -63,7 +63,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
Id = id;
}
public Span<SplitterDestination> GetData(int index)
public readonly Span<SplitterDestination> GetData(int index)
{
int i = 0;
@ -95,7 +95,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
/// Utility function to apply a given <see cref="SpanAction{T, TArg}"/> to all <see cref="Destinations"/>.
/// </summary>
/// <param name="action">The action to execute on each elements.</param>
private void ForEachDestination(SpanAction<SplitterDestination, int> action)
private readonly void ForEachDestination(SpanAction<SplitterDestination, int> action)
{
Span<SplitterDestination> temp = Destinations;
@ -183,7 +183,7 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
/// <summary>
/// Update the internal state of this instance.
/// </summary>
public void UpdateInternalState()
public readonly void UpdateInternalState()
{
ForEachDestination((destination, _) => destination[0].UpdateInternalState());
}
@ -218,4 +218,4 @@ namespace Ryujinx.Audio.Renderer.Server.Splitter
}
}
}
}
}