Make Counter a generic & use a 32-bit counter instead
This commit is contained in:
parent
4478a32114
commit
6c28be13a8
5 changed files with 55 additions and 37 deletions
|
@ -42,7 +42,7 @@ namespace ARMeilleure.Translation
|
|||
public IMemoryManager Memory { get; }
|
||||
|
||||
public JumpTable JumpTable { get; }
|
||||
public EntryTable<byte> CountTable { get; }
|
||||
public EntryTable<uint> CountTable { get; }
|
||||
|
||||
public ulong EntryAddress { get; }
|
||||
public bool HighCq { get; }
|
||||
|
@ -51,7 +51,7 @@ namespace ARMeilleure.Translation
|
|||
public ArmEmitterContext(
|
||||
IMemoryManager memory,
|
||||
JumpTable jumpTable,
|
||||
EntryTable<byte> countTable,
|
||||
EntryTable<uint> countTable,
|
||||
ulong entryAddress,
|
||||
bool highCq,
|
||||
Aarch32Mode mode)
|
||||
|
|
|
@ -540,7 +540,8 @@ namespace ARMeilleure.Translation.PTC
|
|||
}
|
||||
}
|
||||
|
||||
internal static void LoadTranslations(ConcurrentDictionary<ulong, TranslatedFunction> funcs, IMemoryManager memory, JumpTable jumpTable, EntryTable<byte> countTable)
|
||||
internal static void LoadTranslations(ConcurrentDictionary<ulong, TranslatedFunction> funcs, IMemoryManager memory,
|
||||
JumpTable jumpTable, EntryTable<uint> countTable)
|
||||
{
|
||||
if (AreCarriersEmpty())
|
||||
{
|
||||
|
@ -569,7 +570,7 @@ namespace ARMeilleure.Translation.PTC
|
|||
{
|
||||
byte[] code = ReadCode(index, infoEntry.CodeLength);
|
||||
|
||||
Counter callCounter = null;
|
||||
Counter<uint> callCounter = null;
|
||||
|
||||
if (infoEntry.RelocEntriesCount != 0)
|
||||
{
|
||||
|
@ -679,7 +680,8 @@ namespace ARMeilleure.Translation.PTC
|
|||
return relocEntries;
|
||||
}
|
||||
|
||||
private static bool PatchCode(Span<byte> code, RelocEntry[] relocEntries, IntPtr pageTablePointer, JumpTable jumpTable, EntryTable<byte> countTable, out Counter callCounter)
|
||||
private static bool PatchCode(Span<byte> code, RelocEntry[] relocEntries, IntPtr pageTablePointer,
|
||||
JumpTable jumpTable, EntryTable<uint> countTable, out Counter<uint> callCounter)
|
||||
{
|
||||
callCounter = null;
|
||||
|
||||
|
@ -702,7 +704,7 @@ namespace ARMeilleure.Translation.PTC
|
|||
else if (relocEntry.Index == CountTableIndex)
|
||||
{
|
||||
// If we could not allocate an entry on the count table we dip.
|
||||
if (!Counter.TryCreate(countTable, out Counter counter))
|
||||
if (!Counter<uint>.TryCreate(countTable, out Counter<uint> counter))
|
||||
{
|
||||
return false;
|
||||
}
|
||||
|
@ -745,7 +747,8 @@ namespace ARMeilleure.Translation.PTC
|
|||
return new UnwindInfo(pushEntries, prologueSize);
|
||||
}
|
||||
|
||||
private static TranslatedFunction FastTranslate(byte[] code, Counter callCounter, ulong guestSize, UnwindInfo unwindInfo, bool highCq)
|
||||
private static TranslatedFunction FastTranslate(byte[] code, Counter<uint> callCounter, ulong guestSize,
|
||||
UnwindInfo unwindInfo, bool highCq)
|
||||
{
|
||||
CompiledFunction cFunc = new CompiledFunction(code, unwindInfo);
|
||||
|
||||
|
@ -794,7 +797,8 @@ namespace ARMeilleure.Translation.PTC
|
|||
}
|
||||
}
|
||||
|
||||
internal static void MakeAndSaveTranslations(ConcurrentDictionary<ulong, TranslatedFunction> funcs, IMemoryManager memory, JumpTable jumpTable, EntryTable<byte> countTable)
|
||||
internal static void MakeAndSaveTranslations(ConcurrentDictionary<ulong, TranslatedFunction> funcs, IMemoryManager memory,
|
||||
JumpTable jumpTable, EntryTable<uint> countTable)
|
||||
{
|
||||
var profiledFuncsToTranslate = PtcProfiler.GetProfiledFuncsToTranslate(funcs);
|
||||
|
||||
|
|
|
@ -8,12 +8,12 @@ namespace ARMeilleure.Translation
|
|||
{
|
||||
private readonly GuestFunction _func; // Ensure that this delegate will not be garbage collected.
|
||||
|
||||
public Counter CallCounter { get; }
|
||||
public Counter<uint> CallCounter { get; }
|
||||
public ulong GuestSize { get; }
|
||||
public bool HighCq { get; }
|
||||
public IntPtr FuncPtr { get; }
|
||||
|
||||
public TranslatedFunction(GuestFunction func, Counter callCounter, ulong guestSize, bool highCq)
|
||||
public TranslatedFunction(GuestFunction func, Counter<uint> callCounter, ulong guestSize, bool highCq)
|
||||
{
|
||||
_func = func;
|
||||
CallCounter = callCounter;
|
||||
|
|
|
@ -37,7 +37,7 @@ namespace ARMeilleure.Translation
|
|||
|
||||
private JumpTable _jumpTable;
|
||||
internal JumpTable JumpTable => _jumpTable;
|
||||
internal EntryTable<byte> CountTable { get; }
|
||||
internal EntryTable<uint> CountTable { get; }
|
||||
|
||||
private volatile int _threadCount;
|
||||
|
||||
|
@ -59,7 +59,7 @@ namespace ARMeilleure.Translation
|
|||
_backgroundTranslatorEvent = new AutoResetEvent(false);
|
||||
_backgroundTranslatorLock = new ReaderWriterLock();
|
||||
|
||||
CountTable = new EntryTable<byte>(capacity: 16 * 1024 * 1024);
|
||||
CountTable = new EntryTable<uint>(capacity: 4 * 1024 * 1024);
|
||||
|
||||
JitCache.Initialize(allocator);
|
||||
|
||||
|
@ -239,7 +239,7 @@ namespace ARMeilleure.Translation
|
|||
internal static TranslatedFunction Translate(
|
||||
IMemoryManager memory,
|
||||
JumpTable jumpTable,
|
||||
EntryTable<byte> countTable,
|
||||
EntryTable<uint> countTable,
|
||||
ulong address,
|
||||
ExecutionMode mode,
|
||||
bool highCq)
|
||||
|
@ -256,7 +256,7 @@ namespace ARMeilleure.Translation
|
|||
|
||||
Logger.StartPass(PassName.Translation);
|
||||
|
||||
Counter counter = null;
|
||||
Counter<uint> counter = null;
|
||||
|
||||
if (!context.HighCq)
|
||||
{
|
||||
|
@ -415,29 +415,23 @@ namespace ARMeilleure.Translation
|
|||
return context.GetControlFlowGraph();
|
||||
}
|
||||
|
||||
internal static void EmitRejitCheck(ArmEmitterContext context, out Counter counter)
|
||||
internal static void EmitRejitCheck(ArmEmitterContext context, out Counter<uint> counter)
|
||||
{
|
||||
if (!Counter.TryCreate(context.CountTable, out counter))
|
||||
if (!Counter<uint>.TryCreate(context.CountTable, out counter))
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
Operand lblRejit = Label();
|
||||
Operand lblAdd = Label();
|
||||
Operand lblEnd = Label();
|
||||
|
||||
Operand address = Const(ref counter.Value, Ptc.CountTableIndex);
|
||||
Operand count = context.Load8(address);
|
||||
context.BranchIf(lblAdd, count, Const(100), Comparison.LessUI);
|
||||
context.BranchIf(lblRejit, count, Const(100), Comparison.Equal);
|
||||
context.Branch(lblEnd);
|
||||
Operand curCount = context.Load(OperandType.I32, address);
|
||||
Operand count = context.Add(curCount, Const(1));
|
||||
context.Store(address, count);
|
||||
context.BranchIf(lblEnd, curCount, Const(100), Comparison.NotEqual, BasicBlockFrequency.Cold);
|
||||
|
||||
context.MarkLabel(lblRejit, BasicBlockFrequency.Cold);
|
||||
context.Call(typeof(NativeInterface).GetMethod(nameof(NativeInterface.EnqueueForRejit)), Const(context.EntryAddress));
|
||||
|
||||
context.MarkLabel(lblAdd, BasicBlockFrequency.Cold);
|
||||
context.Store8(address, context.Add(count, Const(1)));
|
||||
|
||||
context.MarkLabel(lblEnd);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue