Mirrors/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adjust naming conventions and general refactoring in HLE Project (#527)

Browse source 
* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787c.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Apply previous refactorings to the merged code
This commit is contained in:
Alex Barney 2018-12-06 05:16:24 -06:00 • committed by gdkchan
parent 3615a70cae
commit fb1d9493a3
298 changed files with 12034 additions and 12037 deletions
Download patch file Download diff file Expand all files Collapse all files

52
Ryujinx.HLE/HOS/Services/Am/IStorageAccessor.cs
View file

@ -6,76 +6,76 @@ namespace Ryujinx.HLE.HOS.Services.Am
{
class IStorageAccessor : IpcService
{
private Dictionary<int, ServiceProcessRequest> m_Commands;
private Dictionary<int, ServiceProcessRequest> _commands;
public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
private IStorage Storage;
private IStorage _storage;
public IStorageAccessor(IStorage Storage)
public IStorageAccessor(IStorage storage)
{
m_Commands = new Dictionary<int, ServiceProcessRequest>()
_commands = new Dictionary<int, ServiceProcessRequest>
{
{ 0, GetSize },
{ 10, Write },
{ 11, Read }
};
this.Storage = Storage;
_storage = storage;
}
public long GetSize(ServiceCtx Context)
public long GetSize(ServiceCtx context)
{
Context.ResponseData.Write((long)Storage.Data.Length);
context.ResponseData.Write((long)_storage.Data.Length);
return 0;
}
public long Write(ServiceCtx Context)
public long Write(ServiceCtx context)
{
//TODO: Error conditions.
long WritePosition = Context.RequestData.ReadInt64();
long writePosition = context.RequestData.ReadInt64();
(long Position, long Size) = Context.Request.GetBufferType0x21();
(long position, long size) = context.Request.GetBufferType0x21();
if (Size > 0)
if (size > 0)
{
long MaxSize = Storage.Data.Length - WritePosition;
long maxSize = _storage.Data.Length - writePosition;
if (Size > MaxSize)
if (size > maxSize)
{
Size = MaxSize;
size = maxSize;
}
byte[] Data = Context.Memory.ReadBytes(Position, Size);
byte[] data = context.Memory.ReadBytes(position, size);
Buffer.BlockCopy(Data, 0, Storage.Data, (int)WritePosition, (int)Size);
Buffer.BlockCopy(data, 0, _storage.Data, (int)writePosition, (int)size);
}
return 0;
}
public long Read(ServiceCtx Context)
public long Read(ServiceCtx context)
{
//TODO: Error conditions.
long ReadPosition = Context.RequestData.ReadInt64();
long readPosition = context.RequestData.ReadInt64();
(long Position, long Size) = Context.Request.GetBufferType0x22();
(long position, long size) = context.Request.GetBufferType0x22();
byte[] Data;
byte[] data;
if (Storage.Data.Length > Size)
if (_storage.Data.Length > size)
{
Data = new byte[Size];
data = new byte[size];
Buffer.BlockCopy(Storage.Data, 0, Data, 0, (int)Size);
Buffer.BlockCopy(_storage.Data, 0, data, 0, (int)size);
}
else
{
Data = Storage.Data;
data = _storage.Data;
}
Context.Memory.WriteBytes(Position, Data);
context.Memory.WriteBytes(position, data);
return 0;
}