Made some changes from review comments:

- Made LoadKernelSystemMode return a pair consisting of a system mode and a result code (Could use review).
- Deleted ErrorOpenGL error code in favor of just having ErrorVideoCore.
- Made dialog messages more clear.
- Compared archive ID in fs_user.cpp to ArchiveIdCode::NCCH as opposed to hex magic.
- Cleaned up some other stuff.
This commit is contained in:
TheKoopaKingdom 2017-03-08 20:21:31 -05:00
parent 1ecb322daa
commit 37bec598ea
10 changed files with 55 additions and 53 deletions

View file

@ -179,10 +179,9 @@ public:
/**
* Loads the Exheader and returns the system mode for this application.
* @param boost::optional<u32> Reference to Boost optional to store system mode.
* @return Result of operation.
* @return A pair with the system mode (If found) and the result.
*/
ResultStatus LoadKernelSystemMode(boost::optional<u32>& system_mode) override;
std::pair<boost::optional<u32>, ResultStatus> LoadKernelSystemMode() override;
ResultStatus ReadCode(std::vector<u8>& buffer) override;