Chore: Enable warnings as errors on MSVC (#6456)

* tests: add Sanity test for SplitFilename83

fix test

fix test

* disable `C4715:not all control paths return a value` for nihstro includes

nihstro: no warn

* Chore: Enable warnings as errors on msvc + fix warnings

fixes

some more warnings

clang-format

* more fixes

* Externals: Add target_compile_options `/W0` nihstro-headers and ...

Revert "disable `C4715:not all control paths return a value` for nihstro includes"
This reverts commit 606d79b55d3044b744fb835025b8eb0f4ea5b757.

* src\citra\config.cpp: ReadSetting: simplify type casting

* settings.cpp: Get*Name: remove superflous logs
This commit is contained in:
SachinVin 2023-05-02 01:08:58 +05:30 committed by GitHub
parent 055a58f01e
commit 41f13456c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
71 changed files with 397 additions and 294 deletions

View file

@ -30,7 +30,10 @@ std::string_view GetAudioEmulationName(AudioEmulation emulation) {
return "LLE";
case AudioEmulation::LLEMultithreaded:
return "LLE Multithreaded";
default:
return "Invalid";
}
UNREACHABLE();
};
std::string_view GetGraphicsAPIName(GraphicsAPI api) {
@ -39,7 +42,10 @@ std::string_view GetGraphicsAPIName(GraphicsAPI api) {
return "Software";
case GraphicsAPI::OpenGL:
return "OpenGL";
default:
return "Invalid";
}
UNREACHABLE();
}
std::string_view GetTextureFilterName(TextureFilter filter) {
@ -56,7 +62,10 @@ std::string_view GetTextureFilterName(TextureFilter filter) {
return "ScaleForce";
case TextureFilter::xBRZ:
return "xBRZ";
default:
return "Invalid";
}
UNREACHABLE();
}
} // Anonymous namespace