yuzu/debugger: Specify string conversions explicitly
This commit is contained in:
parent
45ff10c9a0
commit
4832b29d3d
10 changed files with 143 additions and 131 deletions
|
@ -16,15 +16,15 @@ RegistersWidget::RegistersWidget(QWidget* parent) : QDockWidget(parent) {
|
|||
tree->addTopLevelItem(vfp_registers = new QTreeWidgetItem(QStringList(tr("VFP Registers"))));
|
||||
tree->addTopLevelItem(vfp_system_registers =
|
||||
new QTreeWidgetItem(QStringList(tr("VFP System Registers"))));
|
||||
tree->addTopLevelItem(cpsr = new QTreeWidgetItem(QStringList("CPSR")));
|
||||
tree->addTopLevelItem(cpsr = new QTreeWidgetItem(QStringList(QStringLiteral("CPSR"))));
|
||||
|
||||
for (int i = 0; i < 16; ++i) {
|
||||
QTreeWidgetItem* child = new QTreeWidgetItem(QStringList(QString("R[%1]").arg(i)));
|
||||
QTreeWidgetItem* child = new QTreeWidgetItem(QStringList(QStringLiteral("R[%1]").arg(i)));
|
||||
core_registers->addChild(child);
|
||||
}
|
||||
|
||||
for (int i = 0; i < 32; ++i) {
|
||||
QTreeWidgetItem* child = new QTreeWidgetItem(QStringList(QString("S[%1]").arg(i)));
|
||||
QTreeWidgetItem* child = new QTreeWidgetItem(QStringList(QStringLiteral("S[%1]").arg(i)));
|
||||
vfp_registers->addChild(child);
|
||||
}
|
||||
|
||||
|
@ -63,11 +63,11 @@ void RegistersWidget::OnDebugModeEntered() {
|
|||
|
||||
for (int i = 0; i < core_registers->childCount(); ++i)
|
||||
core_registers->child(i)->setText(
|
||||
1, QString("0x%1").arg(Core::CPU().GetReg(i), 8, 16, QLatin1Char('0')));
|
||||
1, QStringLiteral("0x%1").arg(Core::CPU().GetReg(i), 8, 16, QLatin1Char('0')));
|
||||
|
||||
for (int i = 0; i < vfp_registers->childCount(); ++i)
|
||||
vfp_registers->child(i)->setText(
|
||||
1, QString("0x%1").arg(Core::CPU().GetVFPReg(i), 8, 16, QLatin1Char('0')));
|
||||
1, QStringLiteral("0x%1").arg(Core::CPU().GetVFPReg(i), 8, 16, QLatin1Char('0')));
|
||||
|
||||
UpdateCPSRValues();
|
||||
UpdateVFPSystemRegisterValues();
|
||||
|
@ -82,61 +82,61 @@ void RegistersWidget::OnEmulationStarting(EmuThread* emu_thread) {
|
|||
void RegistersWidget::OnEmulationStopping() {
|
||||
// Reset widget text
|
||||
for (int i = 0; i < core_registers->childCount(); ++i)
|
||||
core_registers->child(i)->setText(1, QString(""));
|
||||
core_registers->child(i)->setText(1, QString{});
|
||||
|
||||
for (int i = 0; i < vfp_registers->childCount(); ++i)
|
||||
vfp_registers->child(i)->setText(1, QString(""));
|
||||
vfp_registers->child(i)->setText(1, QString{});
|
||||
|
||||
for (int i = 0; i < cpsr->childCount(); ++i)
|
||||
cpsr->child(i)->setText(1, QString(""));
|
||||
cpsr->child(i)->setText(1, QString{});
|
||||
|
||||
cpsr->setText(1, QString(""));
|
||||
cpsr->setText(1, QString{});
|
||||
|
||||
// FPSCR
|
||||
for (int i = 0; i < vfp_system_registers->child(0)->childCount(); ++i)
|
||||
vfp_system_registers->child(0)->child(i)->setText(1, QString(""));
|
||||
vfp_system_registers->child(0)->child(i)->setText(1, QString{});
|
||||
|
||||
// FPEXC
|
||||
for (int i = 0; i < vfp_system_registers->child(1)->childCount(); ++i)
|
||||
vfp_system_registers->child(1)->child(i)->setText(1, QString(""));
|
||||
vfp_system_registers->child(1)->child(i)->setText(1, QString{});
|
||||
|
||||
vfp_system_registers->child(0)->setText(1, QString(""));
|
||||
vfp_system_registers->child(1)->setText(1, QString(""));
|
||||
vfp_system_registers->child(2)->setText(1, QString(""));
|
||||
vfp_system_registers->child(3)->setText(1, QString(""));
|
||||
vfp_system_registers->child(0)->setText(1, QString{});
|
||||
vfp_system_registers->child(1)->setText(1, QString{});
|
||||
vfp_system_registers->child(2)->setText(1, QString{});
|
||||
vfp_system_registers->child(3)->setText(1, QString{});
|
||||
|
||||
setEnabled(false);
|
||||
}
|
||||
|
||||
void RegistersWidget::CreateCPSRChildren() {
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("M")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("T")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("F")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("I")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("A")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("E")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("IT")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("GE")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("DNM")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("J")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("Q")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("V")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("C")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("Z")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList("N")));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("M"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("T"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("F"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("I"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("A"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("E"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IT"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("GE"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("DNM"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("J"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("Q"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("V"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("C"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("Z"))));
|
||||
cpsr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("N"))));
|
||||
}
|
||||
|
||||
void RegistersWidget::UpdateCPSRValues() {
|
||||
const u32 cpsr_val = Core::CPU().GetCPSR();
|
||||
|
||||
cpsr->setText(1, QString("0x%1").arg(cpsr_val, 8, 16, QLatin1Char('0')));
|
||||
cpsr->setText(1, QStringLiteral("0x%1").arg(cpsr_val, 8, 16, QLatin1Char('0')));
|
||||
cpsr->child(0)->setText(
|
||||
1, QString("b%1").arg(cpsr_val & 0x1F, 5, 2, QLatin1Char('0'))); // M - Mode
|
||||
cpsr->child(1)->setText(1, QString::number((cpsr_val >> 5) & 1)); // T - State
|
||||
cpsr->child(2)->setText(1, QString::number((cpsr_val >> 6) & 1)); // F - FIQ disable
|
||||
cpsr->child(3)->setText(1, QString::number((cpsr_val >> 7) & 1)); // I - IRQ disable
|
||||
cpsr->child(4)->setText(1, QString::number((cpsr_val >> 8) & 1)); // A - Imprecise abort
|
||||
cpsr->child(5)->setText(1, QString::number((cpsr_val >> 9) & 1)); // E - Data endianness
|
||||
1, QStringLiteral("b%1").arg(cpsr_val & 0x1F, 5, 2, QLatin1Char('0'))); // M - Mode
|
||||
cpsr->child(1)->setText(1, QString::number((cpsr_val >> 5) & 1)); // T - State
|
||||
cpsr->child(2)->setText(1, QString::number((cpsr_val >> 6) & 1)); // F - FIQ disable
|
||||
cpsr->child(3)->setText(1, QString::number((cpsr_val >> 7) & 1)); // I - IRQ disable
|
||||
cpsr->child(4)->setText(1, QString::number((cpsr_val >> 8) & 1)); // A - Imprecise abort
|
||||
cpsr->child(5)->setText(1, QString::number((cpsr_val >> 9) & 1)); // E - Data endianness
|
||||
cpsr->child(6)->setText(1,
|
||||
QString::number((cpsr_val >> 10) & 0x3F)); // IT - If-Then state (DNM)
|
||||
cpsr->child(7)->setText(1,
|
||||
|
@ -151,43 +151,43 @@ void RegistersWidget::UpdateCPSRValues() {
|
|||
}
|
||||
|
||||
void RegistersWidget::CreateVFPSystemRegisterChildren() {
|
||||
QTreeWidgetItem* const fpscr = new QTreeWidgetItem(QStringList("FPSCR"));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("IOC")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("DZC")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("OFC")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("UFC")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("IXC")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("IDC")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("IOE")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("DZE")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("OFE")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("UFE")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("IXE")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("IDE")));
|
||||
QTreeWidgetItem* const fpscr = new QTreeWidgetItem(QStringList(QStringLiteral("FPSCR")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IOC"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("DZC"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("OFC"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("UFC"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IXC"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IDC"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IOE"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("DZE"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("OFE"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("UFE"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IXE"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IDE"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(tr("Vector Length"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(tr("Vector Stride"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(tr("Rounding Mode"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("FZ")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("DN")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("V")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("C")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("Z")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList("N")));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("FZ"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("DN"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("V"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("C"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("Z"))));
|
||||
fpscr->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("N"))));
|
||||
|
||||
QTreeWidgetItem* const fpexc = new QTreeWidgetItem(QStringList("FPEXC"));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("IOC")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("OFC")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("UFC")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("INV")));
|
||||
QTreeWidgetItem* const fpexc = new QTreeWidgetItem(QStringList(QStringLiteral("FPEXC")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("IOC"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("OFC"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("UFC"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("INV"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(tr("Vector Iteration Count"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("FP2V")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("EN")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList("EX")));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("FP2V"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("EN"))));
|
||||
fpexc->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("EX"))));
|
||||
|
||||
vfp_system_registers->addChild(fpscr);
|
||||
vfp_system_registers->addChild(fpexc);
|
||||
vfp_system_registers->addChild(new QTreeWidgetItem(QStringList("FPINST")));
|
||||
vfp_system_registers->addChild(new QTreeWidgetItem(QStringList("FPINST2")));
|
||||
vfp_system_registers->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("FPINST"))));
|
||||
vfp_system_registers->addChild(new QTreeWidgetItem(QStringList(QStringLiteral("FPINST2"))));
|
||||
}
|
||||
|
||||
void RegistersWidget::UpdateVFPSystemRegisterValues() {
|
||||
|
@ -197,7 +197,7 @@ void RegistersWidget::UpdateVFPSystemRegisterValues() {
|
|||
const u32 fpinst2_val = Core::CPU().GetVFPSystemReg(VFP_FPINST2);
|
||||
|
||||
QTreeWidgetItem* const fpscr = vfp_system_registers->child(0);
|
||||
fpscr->setText(1, QString("0x%1").arg(fpscr_val, 8, 16, QLatin1Char('0')));
|
||||
fpscr->setText(1, QStringLiteral("0x%1").arg(fpscr_val, 8, 16, QLatin1Char('0')));
|
||||
fpscr->child(0)->setText(1, QString::number(fpscr_val & 1));
|
||||
fpscr->child(1)->setText(1, QString::number((fpscr_val >> 1) & 1));
|
||||
fpscr->child(2)->setText(1, QString::number((fpscr_val >> 2) & 1));
|
||||
|
@ -210,9 +210,12 @@ void RegistersWidget::UpdateVFPSystemRegisterValues() {
|
|||
fpscr->child(9)->setText(1, QString::number((fpscr_val >> 11) & 1));
|
||||
fpscr->child(10)->setText(1, QString::number((fpscr_val >> 12) & 1));
|
||||
fpscr->child(11)->setText(1, QString::number((fpscr_val >> 15) & 1));
|
||||
fpscr->child(12)->setText(1, QString("b%1").arg((fpscr_val >> 16) & 7, 3, 2, QLatin1Char('0')));
|
||||
fpscr->child(13)->setText(1, QString("b%1").arg((fpscr_val >> 20) & 3, 2, 2, QLatin1Char('0')));
|
||||
fpscr->child(14)->setText(1, QString("b%1").arg((fpscr_val >> 22) & 3, 2, 2, QLatin1Char('0')));
|
||||
fpscr->child(12)->setText(
|
||||
1, QStringLiteral("b%1").arg((fpscr_val >> 16) & 7, 3, 2, QLatin1Char('0')));
|
||||
fpscr->child(13)->setText(
|
||||
1, QStringLiteral("b%1").arg((fpscr_val >> 20) & 3, 2, 2, QLatin1Char('0')));
|
||||
fpscr->child(14)->setText(
|
||||
1, QStringLiteral("b%1").arg((fpscr_val >> 22) & 3, 2, 2, QLatin1Char('0')));
|
||||
fpscr->child(15)->setText(1, QString::number((fpscr_val >> 24) & 1));
|
||||
fpscr->child(16)->setText(1, QString::number((fpscr_val >> 25) & 1));
|
||||
fpscr->child(17)->setText(1, QString::number((fpscr_val >> 28) & 1));
|
||||
|
@ -221,18 +224,19 @@ void RegistersWidget::UpdateVFPSystemRegisterValues() {
|
|||
fpscr->child(20)->setText(1, QString::number((fpscr_val >> 31) & 1));
|
||||
|
||||
QTreeWidgetItem* const fpexc = vfp_system_registers->child(1);
|
||||
fpexc->setText(1, QString("0x%1").arg(fpexc_val, 8, 16, QLatin1Char('0')));
|
||||
fpexc->setText(1, QStringLiteral("0x%1").arg(fpexc_val, 8, 16, QLatin1Char('0')));
|
||||
fpexc->child(0)->setText(1, QString::number(fpexc_val & 1));
|
||||
fpexc->child(1)->setText(1, QString::number((fpexc_val >> 2) & 1));
|
||||
fpexc->child(2)->setText(1, QString::number((fpexc_val >> 3) & 1));
|
||||
fpexc->child(3)->setText(1, QString::number((fpexc_val >> 7) & 1));
|
||||
fpexc->child(4)->setText(1, QString("b%1").arg((fpexc_val >> 8) & 7, 3, 2, QLatin1Char('0')));
|
||||
fpexc->child(4)->setText(
|
||||
1, QStringLiteral("b%1").arg((fpexc_val >> 8) & 7, 3, 2, QLatin1Char('0')));
|
||||
fpexc->child(5)->setText(1, QString::number((fpexc_val >> 28) & 1));
|
||||
fpexc->child(6)->setText(1, QString::number((fpexc_val >> 30) & 1));
|
||||
fpexc->child(7)->setText(1, QString::number((fpexc_val >> 31) & 1));
|
||||
|
||||
vfp_system_registers->child(2)->setText(
|
||||
1, QString("0x%1").arg(fpinst_val, 8, 16, QLatin1Char('0')));
|
||||
1, QStringLiteral("0x%1").arg(fpinst_val, 8, 16, QLatin1Char('0')));
|
||||
vfp_system_registers->child(3)->setText(
|
||||
1, QString("0x%1").arg(fpinst2_val, 8, 16, QLatin1Char('0')));
|
||||
1, QStringLiteral("0x%1").arg(fpinst2_val, 8, 16, QLatin1Char('0')));
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue