Miscallenious fixes to gl backend and qt frontend (#6834)

* renderer_gl: Make rasterizer normal class member

* It doesn't need to be heap allocated anymore

* gl_rasterizer: Remove default_texture

* It's unused

* gl_rasterizer: General cleanup

* gl_rasterizer: Lower case lambdas

* Match style with review comments from vulkan backend

* rasterizer_cache: Prevent memory leak

* Since the switch from shared_ptr these surfaces were no longer being destroyed properly. Use our garbage collector for that purpose to destroy it safely for both backends

* rasterizer_cache: Make temp copy of old surface

* The custom surface would override the memory region of the old region resulting in garbage data, this ensures the custom surface is constructed correctly

* citra_qt: Manually create dialog tabs

* Allows for custom constructors which is very useful. While at it, global state is now eliminated from configuration

* citra_qt: Eliminate global system usage

* core: Remove global system usage in memory and HIO

* citra_qt: Use qOverload

* tests: Run clang format

* gl_texture_runtime: Fix surface scaling

src/core/gdbstub/gdbstub.cpp

@@ -36,7 +36,6 @@
 #include "core/gdbstub/gdbstub.h"
 #include "core/gdbstub/hio.h"
 #include "core/hle/kernel/process.h"
-#include "core/loader/loader.h"
 #include "core/memory.h"
 
 namespace GDBStub {
@@ -1035,7 +1034,7 @@ static void RemoveBreakpoint() {
     SendReply("OK");
 }
 
-void HandlePacket() {
+void HandlePacket(Core::System& system) {
     if (!IsConnected()) {
         if (defer_start) {
             ToggleServer(true);
@@ -1076,7 +1075,7 @@ void HandlePacket() {
         Continue();
         return;
     case 'F':
-        HandleHioReply(command_buffer, command_length);
+        HandleHioReply(system, command_buffer, command_length);
         break;
     case 'g':
         ReadRegisters();

src/core/gdbstub/gdbstub.h

@@ -10,6 +10,10 @@
 #include "common/common_types.h"
 #include "core/hle/kernel/thread.h"
 
+namespace Core {
+class System;
+}
+
 namespace GDBStub {
 
 /// Breakpoint Method
@@ -70,7 +74,7 @@ void Break(bool is_memory_break = false);
 bool IsMemoryBreak();
 
 /// Read and handle packet from gdb client.
-void HandlePacket();
+void HandlePacket(Core::System& system);
 
 /**
  * Get the nearest breakpoint of the specified type at the given address.

src/core/gdbstub/hio.cpp

@@ -54,7 +54,7 @@ static void SendErrorReply(int error_code, int retval = -1) {
     SendReply(packet.data());
 }
 
-void SetHioRequest(const VAddr addr) {
+void SetHioRequest(Core::System& system, const VAddr addr) {
     if (!IsServerEnabled()) {
         LOG_WARNING(Debug_GDBStub, "HIO requested but GDB stub is not running");
         return;
@@ -69,15 +69,15 @@ void SetHioRequest(const VAddr addr) {
         LOG_INFO(Debug_GDBStub, "overwriting existing HIO request that was not sent yet");
     }
 
-    auto& memory = Core::System::GetInstance().Memory();
-    const auto process = Core::System::GetInstance().Kernel().GetCurrentProcess();
+    auto& memory = system.Memory();
+    const auto process = system.Kernel().GetCurrentProcess();
 
     if (!memory.IsValidVirtualAddress(*process, addr)) {
         LOG_WARNING(Debug_GDBStub, "Invalid address for HIO request");
         return;
     }
 
-    memory.ReadBlock(*process, addr, &current_hio_request, sizeof(PackedGdbHioRequest));
+    memory.ReadBlock(addr, &current_hio_request, sizeof(PackedGdbHioRequest));
 
     if (current_hio_request.magic != std::array{'G', 'D', 'B', '\0'}) {
         std::string_view bad_magic{
@@ -105,10 +105,11 @@ void SetHioRequest(const VAddr addr) {
     Break();
     SetCpuHaltFlag(true);
     SetCpuStepFlag(false);
-    Core::GetRunningCore().ClearInstructionCache();
+    system.GetRunningCore().ClearInstructionCache();
 }
 
-void HandleHioReply(const u8* const command_buffer, const u32 command_length) {
+void HandleHioReply(Core::System& system, const u8* const command_buffer,
+                    const u32 command_length) {
     if (!IsWaitingForHioReply()) {
         LOG_WARNING(Debug_GDBStub, "Got HIO reply but never sent a request");
         return;
@@ -176,8 +177,8 @@ void HandleHioReply(const u8* const command_buffer, const u32 command_length) {
               current_hio_request.retval, current_hio_request.gdb_errno,
               current_hio_request.ctrl_c);
 
-    const auto process = Core::System::GetInstance().Kernel().GetCurrentProcess();
-    auto& memory = Core::System::GetInstance().Memory();
+    const auto process = system.Kernel().GetCurrentProcess();
+    auto& memory = system.Memory();
 
     // should have been checked when we first initialized the request,
     // but just double check again before we write to memory
@@ -187,8 +188,7 @@ void HandleHioReply(const u8* const command_buffer, const u32 command_length) {
         return;
     }
 
-    memory.WriteBlock(*process, current_hio_request_addr, &current_hio_request,
-                      sizeof(PackedGdbHioRequest));
+    memory.WriteBlock(current_hio_request_addr, &current_hio_request, sizeof(PackedGdbHioRequest));
 
     current_hio_request = {};
     current_hio_request_addr = 0;
@@ -197,7 +197,7 @@ void HandleHioReply(const u8* const command_buffer, const u32 command_length) {
     // Restore state from before the request came in
     SetCpuStepFlag(was_stepping);
     SetCpuHaltFlag(was_halted);
-    Core::GetRunningCore().ClearInstructionCache();
+    system.GetRunningCore().ClearInstructionCache();
 }
 
 bool HandlePendingHioRequestPacket() {

src/core/gdbstub/hio.h

@@ -6,6 +6,10 @@
 
 #include "common/common_types.h"
 
+namespace Core {
+class System;
+}
+
 namespace GDBStub {
 
 /**
@@ -47,7 +51,7 @@ static_assert(sizeof(PackedGdbHioRequest) == 152,
  *
  *  @param address The memory address of the \ref PackedGdbHioRequest.
  */
-void SetHioRequest(const VAddr address);
+void SetHioRequest(Core::System& system, const VAddr address);
 
 /**
  * If there is a pending HIO request, send it to the client.
@@ -59,6 +63,6 @@ bool HandlePendingHioRequestPacket();
 /**
  * Process an HIO reply from the client.
  */
-void HandleHioReply(const u8* const command_buffer, const u32 command_length);
+void HandleHioReply(Core::System& system, const u8* const command_buffer, const u32 command_length);
 
 } // namespace GDBStub