Mirrors/citra-nightly
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Review changes

Browse source
This commit is contained in:
Hamish Milne 2020-03-28 17:08:27 +00:00
parent 86600e90d3
commit 8f164a16ce
12 changed files with 13 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/file_sys/archive_ncch.h
View file

@ -102,7 +102,7 @@ private:
template <class Archive>
void serialize(Archive& ar, const unsigned int) {
ar& boost::serialization::base_object<FileBackend>(*this);
ar& file_buffer; // TODO: See about a more efficient way to do this
ar& file_buffer;
}
friend class boost::serialization::access;
};

2
src/core/file_sys/archive_other_savedata.h
View file

@ -29,7 +29,6 @@ public:
ResultVal<ArchiveFormatInfo> GetFormatInfo(const Path& path, u64 program_id) const override;
private:
std::string mount_point; // TODO: Remove, unused?
std::shared_ptr<ArchiveSource_SDSaveData> sd_savedata_source;
ArchiveFactory_OtherSaveDataPermitted() = default;
@ -57,7 +56,6 @@ public:
ResultVal<ArchiveFormatInfo> GetFormatInfo(const Path& path, u64 program_id) const override;
private:
std::string mount_point; // TODO: Remove, unused?
std::shared_ptr<ArchiveSource_SDSaveData> sd_savedata_source;
ArchiveFactory_OtherSaveDataGeneral() = default;

1
src/core/file_sys/archive_savedata.h
View file

@ -28,7 +28,6 @@ public:
ResultVal<ArchiveFormatInfo> GetFormatInfo(const Path& path, u64 program_id) const override;
private:
std::string mount_point; // TODO: Remove this? seems unused
std::shared_ptr<ArchiveSource_SDSaveData> sd_savedata_source;
ArchiveFactory_SaveData() = default;

4
src/core/file_sys/archive_selfncch.h
View file

@ -58,12 +58,12 @@ public:
private:
/// Mapping of ProgramId -> NCCHData
std::unordered_map<u64, NCCHData>
ncch_data; // TODO: Remove this, or actually set the values here
std::unordered_map<u64, NCCHData> ncch_data;
template <class Archive>
void serialize(Archive& ar, const unsigned int) {
ar& boost::serialization::base_object<ArchiveFactory>(*this);
// NOTE: ncch_data is never written to, so we don't serialize it here
}
friend class boost::serialization::access;
};