yuzu/configuration: Make function naming consistent
This commit is contained in:
Lioncash
fearlessTobi
parent
cae913d3d5
commit
ba6eb5285d
25 changed files with 248 additions and 243 deletions
|
|
@ -32,27 +32,27 @@ ConfigureCamera::ConfigureCamera(QWidget* parent)
|
|||
for (const QCameraInfo& cameraInfo : cameras) {
|
||||
ui->system_camera->addItem(cameraInfo.deviceName());
|
||||
}
|
||||
updateCameraMode();
|
||||
setConfiguration();
|
||||
connectEvents();
|
||||
UpdateCameraMode();
|
||||
SetConfiguration();
|
||||
ConnectEvents();
|
||||
ui->preview_box->setHidden(true);
|
||||
}
|
||||
|
||||
ConfigureCamera::~ConfigureCamera() {
|
||||
stopPreviewing();
|
||||
StopPreviewing();
|
||||
}
|
||||
|
||||
void ConfigureCamera::connectEvents() {
|
||||
void ConfigureCamera::ConnectEvents() {
|
||||
connect(ui->image_source,
|
||||
static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, [this] {
|
||||
stopPreviewing();
|
||||
updateImageSourceUI();
|
||||
StopPreviewing();
|
||||
UpdateImageSourceUI();
|
||||
});
|
||||
connect(ui->camera_selection,
|
||||
static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, [this] {
|
||||
stopPreviewing();
|
||||
if (getCameraSelection() != current_selected) {
|
||||
recordConfig();
|
||||
StopPreviewing();
|
||||
if (GetCameraSelection() != current_selected) {
|
||||
RecordConfig();
|
||||
}
|
||||
if (ui->camera_selection->currentIndex() == 1) {
|
||||
ui->camera_mode->setCurrentIndex(1); // Double
|
||||
|
|
@ -60,26 +60,26 @@ void ConfigureCamera::connectEvents() {
|
|||
ui->camera_mode->setCurrentIndex(0); // Single
|
||||
}
|
||||
}
|
||||
updateCameraMode();
|
||||
setConfiguration();
|
||||
UpdateCameraMode();
|
||||
SetConfiguration();
|
||||
});
|
||||
connect(ui->camera_mode, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
|
||||
this, [this] {
|
||||
stopPreviewing();
|
||||
StopPreviewing();
|
||||
ui->camera_position_label->setVisible(ui->camera_mode->currentIndex() == 1);
|
||||
ui->camera_position->setVisible(ui->camera_mode->currentIndex() == 1);
|
||||
current_selected = getCameraSelection();
|
||||
current_selected = GetCameraSelection();
|
||||
});
|
||||
connect(ui->camera_position,
|
||||
static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, [this] {
|
||||
stopPreviewing();
|
||||
if (getCameraSelection() != current_selected) {
|
||||
recordConfig();
|
||||
StopPreviewing();
|
||||
if (GetCameraSelection() != current_selected) {
|
||||
RecordConfig();
|
||||
}
|
||||
setConfiguration();
|
||||
SetConfiguration();
|
||||
});
|
||||
connect(ui->toolButton, &QToolButton::clicked, this, &ConfigureCamera::onToolButtonClicked);
|
||||
connect(ui->preview_button, &QPushButton::clicked, this, [=] { startPreviewing(); });
|
||||
connect(ui->toolButton, &QToolButton::clicked, this, &ConfigureCamera::OnToolButtonClicked);
|
||||
connect(ui->preview_button, &QPushButton::clicked, this, [=] { StartPreviewing(); });
|
||||
connect(ui->prompt_before_load, &QCheckBox::stateChanged, this, [this](int state) {
|
||||
ui->camera_file->setDisabled(state == Qt::Checked);
|
||||
ui->toolButton->setDisabled(state == Qt::Checked);
|
||||
|
|
@ -87,16 +87,16 @@ void ConfigureCamera::connectEvents() {
|
|||
ui->camera_file->setText("");
|
||||
}
|
||||
});
|
||||
connect(ui->camera_file, &QLineEdit::textChanged, this, [=] { stopPreviewing(); });
|
||||
connect(ui->camera_file, &QLineEdit::textChanged, this, [=] { StopPreviewing(); });
|
||||
connect(ui->system_camera,
|
||||
static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this,
|
||||
[=] { stopPreviewing(); });
|
||||
[=] { StopPreviewing(); });
|
||||
connect(ui->camera_flip, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
|
||||
this, [=] { stopPreviewing(); });
|
||||
this, [=] { StopPreviewing(); });
|
||||
}
|
||||
|
||||
void ConfigureCamera::updateCameraMode() {
|
||||
CameraPosition pos = getCameraSelection();
|
||||
void ConfigureCamera::UpdateCameraMode() {
|
||||
CameraPosition pos = GetCameraSelection();
|
||||
// Set the visibility of the camera mode selection widgets
|
||||
if (pos == CameraPosition::RearBoth) {
|
||||
ui->camera_position->setHidden(true);
|
||||
|
|
@ -111,7 +111,7 @@ void ConfigureCamera::updateCameraMode() {
|
|||
}
|
||||
}
|
||||
|
||||
void ConfigureCamera::updateImageSourceUI() {
|
||||
void ConfigureCamera::UpdateImageSourceUI() {
|
||||
int image_source = ui->image_source->currentIndex();
|
||||
switch (image_source) {
|
||||
case 0: /* blank */
|
||||
|
|
@ -128,7 +128,7 @@ void ConfigureCamera::updateImageSourceUI() {
|
|||
ui->camera_file_label->setHidden(false);
|
||||
ui->camera_file->setHidden(false);
|
||||
ui->toolButton->setHidden(false);
|
||||
if (camera_config[getSelectedCameraIndex()].empty()) {
|
||||
if (camera_config[GetSelectedCameraIndex()].empty()) {
|
||||
ui->prompt_before_load->setChecked(true);
|
||||
ui->camera_file->setDisabled(true);
|
||||
ui->toolButton->setDisabled(true);
|
||||
|
|
@ -147,7 +147,7 @@ void ConfigureCamera::updateImageSourceUI() {
|
|||
ui->camera_flip->setHidden(image_source == 0);
|
||||
}
|
||||
|
||||
void ConfigureCamera::recordConfig() {
|
||||
void ConfigureCamera::RecordConfig() {
|
||||
std::string implementation = Implementations[ui->image_source->currentIndex()];
|
||||
int image_source = ui->image_source->currentIndex();
|
||||
std::string config;
|
||||
|
|
@ -170,14 +170,14 @@ void ConfigureCamera::recordConfig() {
|
|||
camera_config[index] = config;
|
||||
camera_flip[index] = ui->camera_flip->currentIndex();
|
||||
}
|
||||
current_selected = getCameraSelection();
|
||||
current_selected = GetCameraSelection();
|
||||
}
|
||||
|
||||
void ConfigureCamera::startPreviewing() {
|
||||
current_selected = getCameraSelection();
|
||||
recordConfig();
|
||||
int camera_selection = getSelectedCameraIndex();
|
||||
stopPreviewing();
|
||||
void ConfigureCamera::StartPreviewing() {
|
||||
current_selected = GetCameraSelection();
|
||||
RecordConfig();
|
||||
int camera_selection = GetSelectedCameraIndex();
|
||||
StopPreviewing();
|
||||
// Init preview box
|
||||
ui->preview_box->setHidden(false);
|
||||
ui->preview_button->setHidden(true);
|
||||
|
|
@ -190,7 +190,7 @@ void ConfigureCamera::startPreviewing() {
|
|||
camera_name[camera_selection], camera_config[camera_selection], preview_width,
|
||||
preview_height, static_cast<Service::CAM::Flip>(camera_flip[camera_selection]));
|
||||
if (!previewing_camera) {
|
||||
stopPreviewing();
|
||||
StopPreviewing();
|
||||
return;
|
||||
}
|
||||
previewing_camera->SetResolution(
|
||||
|
|
@ -204,7 +204,7 @@ void ConfigureCamera::startPreviewing() {
|
|||
timer_id = startTimer(1000 / 30);
|
||||
}
|
||||
|
||||
void ConfigureCamera::stopPreviewing() {
|
||||
void ConfigureCamera::StopPreviewing() {
|
||||
ui->preview_box->setHidden(true);
|
||||
ui->preview_button->setHidden(false);
|
||||
|
||||
|
|
@ -231,7 +231,7 @@ void ConfigureCamera::timerEvent(QTimerEvent* event) {
|
|||
int width = ui->preview_box->size().width();
|
||||
int height = width * 0.75;
|
||||
if (width != preview_width || height != preview_height) {
|
||||
stopPreviewing();
|
||||
StopPreviewing();
|
||||
return;
|
||||
}
|
||||
QImage image(width, height, QImage::Format::Format_RGB16);
|
||||
|
|
@ -239,8 +239,8 @@ void ConfigureCamera::timerEvent(QTimerEvent* event) {
|
|||
ui->preview_box->setPixmap(QPixmap::fromImage(image));
|
||||
}
|
||||
|
||||
void ConfigureCamera::setConfiguration() {
|
||||
int index = getSelectedCameraIndex();
|
||||
void ConfigureCamera::SetConfiguration() {
|
||||
int index = GetSelectedCameraIndex();
|
||||
for (int i = 0; i < Implementations.size(); i++) {
|
||||
if (Implementations[i] == camera_name[index]) {
|
||||
ui->image_source->setCurrentIndex(i);
|
||||
|
|
@ -262,11 +262,11 @@ void ConfigureCamera::setConfiguration() {
|
|||
ui->camera_file->setText(QString::fromStdString(camera_config[index]));
|
||||
}
|
||||
ui->camera_flip->setCurrentIndex(camera_flip[index]);
|
||||
updateImageSourceUI();
|
||||
UpdateImageSourceUI();
|
||||
}
|
||||
|
||||
void ConfigureCamera::onToolButtonClicked() {
|
||||
stopPreviewing();
|
||||
void ConfigureCamera::OnToolButtonClicked() {
|
||||
StopPreviewing();
|
||||
QList<QByteArray> types = QImageReader::supportedImageFormats();
|
||||
QList<QString> temp_filters;
|
||||
for (const QByteArray& type : types) {
|
||||
|
|
@ -279,15 +279,15 @@ void ConfigureCamera::onToolButtonClicked() {
|
|||
}
|
||||
}
|
||||
|
||||
void ConfigureCamera::applyConfiguration() {
|
||||
recordConfig();
|
||||
stopPreviewing();
|
||||
void ConfigureCamera::ApplyConfiguration() {
|
||||
RecordConfig();
|
||||
StopPreviewing();
|
||||
Settings::values.camera_name = camera_name;
|
||||
Settings::values.camera_config = camera_config;
|
||||
Settings::values.camera_flip = camera_flip;
|
||||
}
|
||||
|
||||
ConfigureCamera::CameraPosition ConfigureCamera::getCameraSelection() {
|
||||
ConfigureCamera::CameraPosition ConfigureCamera::GetCameraSelection() {
|
||||
switch (ui->camera_selection->currentIndex()) {
|
||||
case 0: // Front
|
||||
return CameraPosition::Front;
|
||||
|
|
@ -306,8 +306,8 @@ ConfigureCamera::CameraPosition ConfigureCamera::getCameraSelection() {
|
|||
}
|
||||
}
|
||||
|
||||
int ConfigureCamera::getSelectedCameraIndex() {
|
||||
CameraPosition pos = getCameraSelection();
|
||||
int ConfigureCamera::GetSelectedCameraIndex() {
|
||||
CameraPosition pos = GetCameraSelection();
|
||||
int camera_selection = static_cast<int>(pos);
|
||||
if (pos == CameraPosition::RearBoth) { // Single Mode
|
||||
camera_selection = 0; // Either camera is the same, so we return RearRight
|
||||
|
|
@ -315,6 +315,6 @@ int ConfigureCamera::getSelectedCameraIndex() {
|
|||
return camera_selection;
|
||||
}
|
||||
|
||||
void ConfigureCamera::retranslateUi() {
|
||||
void ConfigureCamera::RetranslateUI() {
|
||||
ui->retranslateUi(this);
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue