Address review comments

* Convert %x to {:x}
* Convert {0:#010x} to {:#010x}
* Remove `? true : false` statement
* Remove `.c_str()` for strings
This commit is contained in:
Daniel Lim Wee Soong 2018-03-24 22:25:50 +08:00
parent 693b190274
commit df816b5eaf
8 changed files with 17 additions and 17 deletions

View file

@ -59,7 +59,7 @@ SDL2Sink::SDL2Sink() : impl(std::make_unique<Impl>()) {
device, false, &desired_audiospec, &obtained_audiospec, SDL_AUDIO_ALLOW_FREQUENCY_CHANGE);
if (impl->audio_device_id <= 0) {
NGLOG_CRITICAL(Audio_Sink, "SDL_OpenAudioDevice failed with code {} for device \"{}\"",
impl->audio_device_id, Settings::values.audio_device_id.c_str());
impl->audio_device_id, Settings::values.audio_device_id);
return;
}