Mirrors/citra-nightly
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Multiplayer: Send an error message when connecting to a full room

Browse source
This commit is contained in:
James Rowe 2018-04-20 01:34:37 -06:00 • committed by zhupengfei
parent a9c9ffd32c
commit e040bc9355
No known key found for this signature in database
GPG key ID: DD129E108BD09378
7 changed files with 42 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/network/room.cpp
View file

@ -68,6 +68,11 @@ public:
*/
bool IsValidMacAddress(const MacAddress& address) const;
/**
* Sends a ID_ROOM_IS_FULL message telling the client that the room is full.
*/
void SendRoomIsFull(ENetPeer* client);
/**
* Sends a ID_ROOM_NAME_COLLISION message telling the client that the name is invalid.
*/
@ -193,6 +198,13 @@ void Room::RoomImpl::StartLoop() {
}
void Room::RoomImpl::HandleJoinRequest(const ENetEvent* event) {
{
std::lock_guard<std::mutex> lock(member_mutex);
if (members.size() >= room_information.member_slots) {
SendRoomIsFull(event->peer);
return;
}
}
Packet packet;
packet.Append(event->packet->data, event->packet->dataLength);
packet.IgnoreBytes(sizeof(u8)); // Ignore the message type
@ -295,6 +307,16 @@ void Room::RoomImpl::SendWrongPassword(ENetPeer* client) {
enet_host_flush(server);
}
void Room::RoomImpl::SendRoomIsFull(ENetPeer* client) {
Packet packet;
packet << static_cast<u8>(IdRoomIsFull);
ENetPacket* enet_packet =
enet_packet_create(packet.GetData(), packet.GetDataSize(), ENET_PACKET_FLAG_RELIABLE);
enet_peer_send(client, 0, enet_packet);
enet_host_flush(server);
}
void Room::RoomImpl::SendVersionMismatch(ENetPeer* client) {
Packet packet;
packet << static_cast<u8>(IdVersionMismatch);
@ -527,7 +549,9 @@ bool Room::Create(const std::string& name, const std::string& server_address, u1
}
address.port = server_port;
room_impl->server = enet_host_create(&address, max_connections, NumChannels, 0, 0);
// In order to send the room is full message to the connecting client, we need to leave one slot
// open so enet won't reject the incoming connection without telling us
room_impl->server = enet_host_create(&address, max_connections + 1, NumChannels, 0, 0);
if (!room_impl->server) {
return false;
}