Mirrors/pico-uart-bridge
1
0
Fork 0
mirror of https://github.com/Noltari/pico-uart-bridge.git synced 2025-05-14 08:12:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Switch from memcpy to memmove when copying within buffers

Browse source 
In the usb_write_bytes and uart_write_bytes routines, a memcpy was previously
used to copy untransmitted bytes to the beginning of the buffer (ud->uart_buffer
and ud->usb_buffer, respectively). Since the source and destination regions of
memory may potentially overlap, the use of memcpy may lead to undefined results.

From the draft C89 standard:

    4.11.2.1 The memcpy function

    Synopsis

             #include <string.h>
             void *memcpy(void *s1, const void *s2, size_t n);

    Description

       The memcpy function copies n characters from the object pointed to
    by s2 into the object pointed to by s1 .  If copying takes place
    between objects that overlap, the behavior is undefined.

    Returns

       The memcpy function returns the value of s1 .

By using memmove rather than memcpy in the usb_write_bytes and uart_write_bytes
routines, the potential for undefined behavior can be avoided.
This commit is contained in:
Michael Duda 2023-01-29 11:49:11 -07:00
parent 9d05ed4b1d
commit 67ce07178f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
uart-bridge.c
View file

@ -157,7 +157,7 @@ void usb_write_bytes(uint8_t itf)
count = tud_cdc_n_write(itf, ud->uart_buffer, ud->uart_pos); count = tud_cdc_n_write(itf, ud->uart_buffer, ud->uart_pos);
if (count < ud->uart_pos) if (count < ud->uart_pos)
memcpy(ud->uart_buffer, &ud->uart_buffer[count], memmove(ud->uart_buffer, &ud->uart_buffer[count],
ud->uart_pos - count); ud->uart_pos - count);
ud->uart_pos -= count; ud->uart_pos -= count;
@ -245,7 +245,7 @@ void uart_write_bytes(uint8_t itf)
} }
if (count < ud->usb_pos) if (count < ud->usb_pos)
memcpy(ud->usb_buffer, &ud->usb_buffer[count], memmove(ud->usb_buffer, &ud->usb_buffer[count],
ud->usb_pos - count); ud->usb_pos - count);
ud->usb_pos -= count; ud->usb_pos -= count;