Use fs::path::native whenever possible, avoid unnecessary fs->string conversions in GUI code (#1064)

* Use filesystem::path whenever possible, remove fs::path::string

* My hatred for Windows grows with every passing day

* More Qt stuff

* custom u8string formatter for fmt library

* Use u8string for imgui

* Fix toml errors hopefully

* Fix not printing issue

* Oh and on SDL

* I hate Windows even more today

* fix toml reading utf-8 paths

also small fix for fmt::UTF

* Formatting

* Fix QT path to run games

* Fix path logging in save data

* Fix trophy path handling

* Update game_list_frame.cpp

fixed snd0path

* Update main_window.cpp

fix snd0path

* Update main_window.cpp

* paths finally fixed

* git info in WIP versions title

---------

Co-authored-by: Vinicius Rangel <me@viniciusrangel.dev>
Co-authored-by: georgemoralis <giorgosmrls@gmail.com>

src/core/file_format/pkg.cpp

@@ -371,8 +371,7 @@ bool PKG::Extract(const std::filesystem::path& filepath, const std::filesystem::
                 if (table.type == PFS_CURRENT_DIR) {
                     current_dir = extractPaths[table.inode];
                 }
-                extractPaths[table.inode] =
-                    current_dir.string() / std::filesystem::path(table.name);
+                extractPaths[table.inode] = current_dir / std::filesystem::path(table.name);
 
                 if (table.type == PFS_FILE || table.type == PFS_DIR) {
                     if (table.type == PFS_DIR) { // Create dirs.
@@ -402,7 +401,7 @@ void PKG::ExtractFiles(const int index) {
         int bsize = iNodeBuf[inode_number].Size;
 
         Common::FS::IOFile inflated;
-        inflated.Open(extractPaths[inode_number].string(), Common::FS::FileAccessMode::Write);
+        inflated.Open(extractPaths[inode_number], Common::FS::FileAccessMode::Write);
 
         Common::FS::IOFile pkgFile; // Open the file for each iteration to avoid conflict.
         pkgFile.Open(pkgpath, Common::FS::FileAccessMode::Read);

src/core/file_format/splash.cpp

@@ -12,8 +12,8 @@
 #define STBI_NO_STDIO
 #include "externals/stb_image.h"
 
-bool Splash::Open(const std::string& filepath) {
-    ASSERT_MSG(filepath.ends_with(".png"), "Unexpected file format passed");
+bool Splash::Open(const std::filesystem::path& filepath) {
+    ASSERT_MSG(filepath.stem().string() != "png", "Unexpected file format passed");
 
     Common::FS::IOFile file(filepath, Common::FS::FileAccessMode::Read);
     if (!file.IsOpen()) {

src/core/file_format/splash.h

@@ -3,6 +3,7 @@
 
 #pragma once
 
+#include <filesystem>
 #include <string>
 #include <vector>
 #include "common/types.h"
@@ -22,7 +23,7 @@ public:
     Splash() = default;
     ~Splash() = default;
 
-    bool Open(const std::string& filepath);
+    bool Open(const std::filesystem::path& filepath);
     [[nodiscard]] bool IsLoaded() const {
         return img_data.size();
     }

src/core/file_format/trp.cpp

@@ -29,7 +29,7 @@ static void removePadding(std::vector<u8>& vec) {
 }
 
 bool TRP::Extract(const std::filesystem::path& trophyPath) {
-    std::string title = trophyPath.filename().string();
+    std::filesystem::path title = trophyPath.filename();
     std::filesystem::path gameSysDir = trophyPath / "sce_sys/trophy/";
     if (!std::filesystem::exists(gameSysDir)) {
         return false;