Fixed return strict const iterator, replace to range-based loop C++17 and code refactor (#548)

Signed-off-by: Herman Semenov <GermanAizek@yandex.ru>
Co-authored-by: georgemoralis <giorgosmrls@gmail.com>

src/core/libraries/kernel/threads/semaphore.cpp

@@ -59,7 +59,7 @@ public:
         for (auto it = wait_list.begin(); it != wait_list.end();) {
             auto* waiter = *it;
             if (waiter->need_count > token_count) {
-                it++;
+                ++it;
                 continue;
             }
             it = wait_list.erase(it);
@@ -148,7 +148,7 @@ public:
         // Find the first with priority less then us and insert right before it.
         auto it = wait_list.begin();
         while (it != wait_list.end() && (*it)->priority > waiter->priority) {
-            it++;
+            ++it;
         }
         wait_list.insert(it, waiter);
         return it;

src/core/memory.cpp

@@ -98,7 +98,7 @@ PAddr MemoryManager::Allocate(PAddr search_start, PAddr search_end, size_t size,
         return dmem_area->second.is_free && remaining_size >= size;
     };
     while (!is_suitable() && dmem_area->second.GetEnd() <= search_end) {
-        dmem_area++;
+        ++dmem_area;
     }
     ASSERT_MSG(is_suitable(), "Unable to find free direct memory area: size = {:#x}", size);
 
@@ -487,7 +487,7 @@ int MemoryManager::VirtualQuery(VAddr addr, int flags,
 
     auto it = FindVMA(addr);
     if (it->second.type == VMAType::Free && flags == 1) {
-        it++;
+        ++it;
     }
     if (it->second.type == VMAType::Free) {
         LOG_WARNING(Kernel_Vmm, "VirtualQuery on free memory region");
@@ -603,7 +603,7 @@ VAddr MemoryManager::SearchFree(VAddr virtual_addr, size_t size, u32 alignment)
         return remaining_size >= size;
     };
     while (!is_suitable()) {
-        it++;
+        ++it;
     }
     return virtual_addr;
 }