core: Many things (#194)

* video_core: Add a few missed things

* libkernel: More proper memory mapped files

* memory: Fix tessellation buffer mapping

* Cuphead work

* sceKernelPollSema fix

* clang format

* fixed ngs2 lle loading and rtc lib

* draft pthreads keys implementation

* fixed return codes

* return error code if sceKernelLoadStartModule module is invalid

* re-enabled system modules and disable debug in libs.h

* Improve linux support

* fix windows build

* kernel: Rework keys

---------

Co-authored-by: georgemoralis <giorgosmrls@gmail.com>

src/video_core/texture_cache/image.h

@@ -88,6 +88,8 @@ private:
     vk::Image image{};
 };
 
+constexpr SlotId NULL_IMAGE_ID{0};
+
 struct Image {
     explicit Image(const Vulkan::Instance& instance, Vulkan::Scheduler& scheduler,
                    const ImageInfo& info, VAddr cpu_addr);

src/video_core/texture_cache/image_view.cpp

@@ -46,17 +46,20 @@ vk::ComponentSwizzle ConvertComponentSwizzle(u32 dst_sel) {
     }
 }
 
-ImageViewInfo::ImageViewInfo(const AmdGpu::Image& image) noexcept {
+ImageViewInfo::ImageViewInfo(const AmdGpu::Image& image, bool is_storage) noexcept
+    : is_storage{is_storage} {
     type = ConvertImageViewType(image.type);
     format = Vulkan::LiverpoolToVK::SurfaceFormat(image.GetDataFmt(), image.GetNumberFmt());
     range.base.level = 0;
     range.base.layer = 0;
     range.extent.levels = image.NumLevels();
     range.extent.layers = image.NumLayers();
-    mapping.r = ConvertComponentSwizzle(image.dst_sel_x);
-    mapping.g = ConvertComponentSwizzle(image.dst_sel_y);
-    mapping.b = ConvertComponentSwizzle(image.dst_sel_z);
-    mapping.a = ConvertComponentSwizzle(image.dst_sel_w);
+    if (!is_storage) {
+        mapping.r = ConvertComponentSwizzle(image.dst_sel_x);
+        mapping.g = ConvertComponentSwizzle(image.dst_sel_y);
+        mapping.b = ConvertComponentSwizzle(image.dst_sel_z);
+        mapping.a = ConvertComponentSwizzle(image.dst_sel_w);
+    }
 }
 
 ImageView::ImageView(const Vulkan::Instance& instance, const ImageViewInfo& info_, Image& image,
@@ -74,7 +77,7 @@ ImageView::ImageView(const Vulkan::Instance& instance, const ImageViewInfo& info
     }
 
     const vk::ImageViewCreateInfo image_view_ci = {
-        .pNext = usage_override.has_value() ? &usage_ci : nullptr,
+        .pNext = nullptr,
         .image = image.image,
         .viewType = info.type,
         .format = format,

src/video_core/texture_cache/image_view.h

@@ -18,12 +18,13 @@ namespace VideoCore {
 
 struct ImageViewInfo {
     explicit ImageViewInfo() = default;
-    explicit ImageViewInfo(const AmdGpu::Image& image) noexcept;
+    explicit ImageViewInfo(const AmdGpu::Image& image, bool is_storage) noexcept;
 
     vk::ImageViewType type = vk::ImageViewType::e2D;
     vk::Format format = vk::Format::eR8G8B8A8Unorm;
     SubresourceRange range;
     vk::ComponentMapping mapping{};
+    bool is_storage;
 
     auto operator<=>(const ImageViewInfo&) const = default;
 };

src/video_core/texture_cache/texture_cache.cpp

@@ -169,14 +169,14 @@ ImageView& TextureCache::FindImageView(const AmdGpu::Image& desc, bool is_storag
         image.Transit(vk::ImageLayout::eShaderReadOnlyOptimal, vk::AccessFlagBits::eShaderRead);
     }
 
-    const ImageViewInfo view_info{desc};
+    const ImageViewInfo view_info{desc, is_storage};
     return RegisterImageView(image, view_info);
 }
 
 ImageView& TextureCache::RenderTarget(const AmdGpu::Liverpool::ColorBuffer& buffer,
                                       const AmdGpu::Liverpool::CbDbExtent& hint) {
     const ImageInfo info{buffer, hint};
-    auto& image = FindImage(info, buffer.Address());
+    auto& image = FindImage(info, buffer.Address(), false);
     image.flags &= ~ImageFlagBits::CpuModified;
 
     image.Transit(vk::ImageLayout::eColorAttachmentOptimal,

src/video_core/texture_cache/texture_cache.h

@@ -55,6 +55,11 @@ public:
     /// Retrieves the sampler that matches the provided S# descriptor.
     [[nodiscard]] vk::Sampler GetSampler(const AmdGpu::Sampler& sampler);
 
+    /// Retrieves the image with the specified id.
+    [[nodiscard]] Image& GetImage(ImageId id) {
+        return slot_images[id];
+    }
+
 private:
     ImageView& RegisterImageView(Image& image, const ImageViewInfo& view_info);