input_common: Treat warnings as errors

Migrates over warnings as errors for input common to match how the
common library treats warnings as errors.
This commit is contained in:
Lioncash 2020-11-15 06:22:01 -05:00
parent 3a85bc1e77
commit 5c4774e8ce
8 changed files with 23 additions and 10 deletions

View file

@ -63,7 +63,7 @@ public:
}
private:
void HandleReceive(const boost::system::error_code& error, std::size_t bytes_transferred) {
void HandleReceive(const boost::system::error_code&, std::size_t bytes_transferred) {
if (auto type = Response::Validate(receive_buffer.data(), bytes_transferred)) {
switch (*type) {
case Type::Version: {
@ -90,7 +90,7 @@ private:
StartReceive();
}
void HandleSend(const boost::system::error_code& error) {
void HandleSend(const boost::system::error_code&) {
boost::system::error_code _ignored{};
// Send a request for getting port info for the pad
const Request::PortInfo port_info{1, {static_cast<u8>(pad_index), 0, 0, 0}};
@ -369,7 +369,7 @@ CalibrationConfigurationJob::CalibrationConfigurationJob(
u16 max_y{};
Status current_status{Status::Initialized};
SocketCallback callback{[](Response::Version version) {}, [](Response::PortInfo info) {},
SocketCallback callback{[](Response::Version) {}, [](Response::PortInfo) {},
[&](Response::PadData data) {
if (current_status == Status::Initialized) {
// Receiving data means the communication is ready now

View file

@ -7,7 +7,16 @@
#include <array>
#include <optional>
#include <type_traits>
#ifdef _MSC_VER
#pragma warning(push)
#pragma warning(disable : 4701)
#endif
#include <boost/crc.hpp>
#ifdef _MSC_VER
#pragma warning(pop)
#endif
#include "common/bit_field.h"
#include "common/swap.h"
@ -93,7 +102,7 @@ static_assert(std::is_trivially_copyable_v<PadData>,
/**
* Creates a message with the proper header data that can be sent to the server.
* @param T data Request body to send
* @param data Request body to send
* @param client_id ID of the udp client (usually not checked on the server)
*/
template <typename T>