loader: Make ResultStatus directly compatible with fmt

We can make the enum class type compatible with fmt by providing an
overload of operator<<.

While we're at it, perform proper bounds checking. If something exceeds
the array, it should be a hard fail, because it's, without a doubt, a
programmer error in this case.
This commit is contained in:
Lioncash 2018-08-15 05:38:37 -04:00
parent 301baaa942
commit 87d8a9c986
5 changed files with 18 additions and 14 deletions

View file

@ -4,11 +4,14 @@
#include <array>
#include <string>
#include <core/loader/loader.h>
#include <fmt/ostream.h>
#include "common/logging/log.h"
#include "core/file_sys/card_image.h"
#include "core/file_sys/partition_filesystem.h"
#include "core/file_sys/vfs_offset.h"
#include "core/loader/loader.h"
namespace FileSys {
@ -142,7 +145,7 @@ Loader::ResultStatus XCI::AddNCAFromPartition(XCIPartition part) {
const u16 error_id = static_cast<u16>(nca->GetStatus());
LOG_CRITICAL(Loader, "Could not load NCA {}/{}, failed with error code {:04X} ({})",
partition_names[static_cast<size_t>(part)], nca->GetName(), error_id,
Loader::GetMessageForResultStatus(nca->GetStatus()));
nca->GetStatus());
}
}