core: Fix clang build

Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.

Fixes #4795
This commit is contained in:
Lioncash 2020-10-15 14:49:45 -04:00
parent ca416a0fb8
commit be1954e04c
105 changed files with 906 additions and 667 deletions

View file

@ -143,6 +143,7 @@ u64 GetSignatureTypeDataSize(SignatureType type) {
return 0x3C;
}
UNREACHABLE();
return 0;
}
u64 GetSignatureTypePaddingSize(SignatureType type) {
@ -157,6 +158,7 @@ u64 GetSignatureTypePaddingSize(SignatureType type) {
return 0x40;
}
UNREACHABLE();
return 0;
}
SignatureType Ticket::GetSignatureType() const {
@ -171,6 +173,7 @@ SignatureType Ticket::GetSignatureType() const {
}
UNREACHABLE();
return {};
}
TicketData& Ticket::GetData() {
@ -348,7 +351,7 @@ std::optional<Key128> DeriveSDSeed() {
std::array<u8, 0x10> buffer{};
std::size_t offset = 0;
for (; offset + 0x10 < save_43.GetSize(); ++offset) {
if (!save_43.Seek(offset, SEEK_SET)) {
if (!save_43.Seek(static_cast<s64>(offset), SEEK_SET)) {
return std::nullopt;
}
@ -358,7 +361,7 @@ std::optional<Key128> DeriveSDSeed() {
}
}
if (!save_43.Seek(offset + 0x10, SEEK_SET)) {
if (!save_43.Seek(static_cast<s64>(offset + 0x10), SEEK_SET)) {
return std::nullopt;
}