Mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID

Browse source 
- Use .at() instead of raw indexing when dealing with untrusted indices.

- For the special case of WaitFence with syncpoint id UINT32_MAX,
  instead of crashing, log an error and ignore.  This is what I get when
  running Super Mario Maker 2.
This commit is contained in:
comex 2020-11-22 15:48:23 -05:00
parent 5d1447897a
commit e8b2fd21d8
2 changed files with 20 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core/hle/service/nvdrv/syncpoint_manager.h
View file

@ -37,7 +37,7 @@ public:
* @returns The lower bound for the specified syncpoint.
*/
u32 GetSyncpointMin(u32 syncpoint_id) const {
return syncpoints[syncpoint_id].min.load(std::memory_order_relaxed);
return syncpoints.at(syncpoint_id).min.load(std::memory_order_relaxed);
}
/**
@ -46,7 +46,7 @@ public:
* @returns The upper bound for the specified syncpoint.
*/
u32 GetSyncpointMax(u32 syncpoint_id) const {
return syncpoints[syncpoint_id].max.load(std::memory_order_relaxed);
return syncpoints.at(syncpoint_id).max.load(std::memory_order_relaxed);
}
/**