Mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

audio_renderer: resolve adsp thread deadlock shutdown

Browse source
This commit is contained in:
Liam 2023-06-04 12:56:40 -04:00
parent 125a0e5a07
commit e96a3a1713
4 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/audio_core/sink/sink_stream.cpp
View file

@ -269,12 +269,13 @@ u64 SinkStream::GetExpectedPlayedSampleCount() {
return std::min<u64>(exp_played_sample_count, max_played_sample_count) + TargetSampleCount * 3;
}
void SinkStream::WaitFreeSpace() {
void SinkStream::WaitFreeSpace(std::stop_token stop_token) {
std::unique_lock lk{release_mutex};
release_cv.wait_for(lk, std::chrono::milliseconds(5),
[this]() { return queued_buffers < max_queue_size; });
if (queued_buffers > max_queue_size + 3) {
release_cv.wait(lk, [this]() { return queued_buffers < max_queue_size; });
Common::CondvarWait(release_cv, lk, stop_token,
[this] { return queued_buffers < max_queue_size; });
}
}

5
src/audio_core/sink/sink_stream.h
View file

@ -13,6 +13,7 @@
#include "audio_core/common/common.h"
#include "common/common_types.h"
#include "common/polyfill_thread.h"
#include "common/reader_writer_queue.h"
#include "common/ring_buffer.h"
#include "common/thread.h"
@ -210,7 +211,7 @@ public:
/**
* Waits for free space in the sample ring buffer
*/
void WaitFreeSpace();
void WaitFreeSpace(std::stop_token stop_token);
protected:
/// Core system
@ -252,7 +253,7 @@ private:
/// Set via IAudioDevice service calls
f32 device_volume{1.0f};
/// Signalled when ring buffer entries are consumed
std::condition_variable release_cv;
std::condition_variable_any release_cv;
std::mutex release_mutex;
};