Addressed Bunnei's review comments, and made some other tweaks:
- Deleted GetStatus() because it wasn't used anywhere outside of Core::System. - Fixed design flaw where the message bar status could be set despite the game being stopped.
This commit is contained in:
parent
ff04320c97
commit
f008b22e3b
7 changed files with 32 additions and 29 deletions
|
@ -663,10 +663,11 @@ void GMainWindow::OnCoreError(Core::System::ResultStatus result, std::string det
|
|||
switch (result) {
|
||||
case Core::System::ResultStatus::ErrorSystemFiles: {
|
||||
QString message = "Citra was unable to locate a 3DS system archive";
|
||||
if (details != std::string())
|
||||
if (!details.empty()) {
|
||||
message.append(tr(": %1. ").arg(details.c_str()));
|
||||
else
|
||||
} else {
|
||||
message.append(". ");
|
||||
}
|
||||
message.append(common_message);
|
||||
|
||||
answer = QMessageBox::question(this, tr("System Archive Not Found"), message,
|
||||
|
@ -698,11 +699,15 @@ void GMainWindow::OnCoreError(Core::System::ResultStatus result, std::string det
|
|||
}
|
||||
|
||||
if (answer == QMessageBox::Yes) {
|
||||
if (emu_thread != nullptr)
|
||||
if (emu_thread) {
|
||||
ShutdownGame();
|
||||
}
|
||||
} else {
|
||||
message_label->setText(status_message);
|
||||
message_label->setVisible(true);
|
||||
// Only show the message if the game is still running.
|
||||
if (emu_thread) {
|
||||
message_label->setText(status_message);
|
||||
message_label->setVisible(true);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue