Addressed Bunnei's review comments, and made some other tweaks:
- Deleted GetStatus() because it wasn't used anywhere outside of Core::System. - Fixed design flaw where the message bar status could be set despite the game being stopped.
This commit is contained in:
parent
ff04320c97
commit
f008b22e3b
7 changed files with 32 additions and 29 deletions
|
@ -108,16 +108,14 @@ public:
|
|||
PerfStats perf_stats;
|
||||
FrameLimiter frame_limiter;
|
||||
|
||||
ResultStatus GetStatus() {
|
||||
return status;
|
||||
}
|
||||
|
||||
void SetStatus(ResultStatus new_status, std::string details = std::string()) {
|
||||
void SetStatus(ResultStatus new_status, const char* details = nullptr) {
|
||||
status = new_status;
|
||||
status_details = details;
|
||||
if (details) {
|
||||
status_details = details;
|
||||
}
|
||||
}
|
||||
|
||||
std::string GetStatusDetails() {
|
||||
const std::string& GetStatusDetails() const {
|
||||
return status_details;
|
||||
}
|
||||
|
||||
|
@ -147,8 +145,8 @@ private:
|
|||
|
||||
static System s_instance;
|
||||
|
||||
ResultStatus status;
|
||||
std::string status_details;
|
||||
ResultStatus status = ResultStatus::Success;
|
||||
std::string status_details = "";
|
||||
};
|
||||
|
||||
inline ARM_Interface& CPU() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue